Skip to content

8346048: test/lib/containers/docker/DockerRunOptions.java uses addJavaOpts() from ctor #3133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sendaoYan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

8346048: test/lib/containers/docker/DockerRunOptions.java uses addJavaOpts() from ctor #3133

sendaoYan wants to merge 1 commit into from

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Dec 10, 2025 •
edited by openjdk bot
Loading

Hi all,

This pull request contains a backport of commit 390b2053 from the openjdk/jdk repository.

The commit being backported was authored by Leonid Mesnik on 17 Dec 2024 and was reviewed by David Holmes.

Thanks!

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8346048 needs maintainer approval

Issue

  • JDK-8346048: test/lib/containers/docker/DockerRunOptions.java uses addJavaOpts() from ctor (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3133/head:pull/3133
$ git checkout pull/3133

Update a local copy of the PR:
$ git checkout pull/3133
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3133/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3133

View PR using the GUI difftool:
$ git pr show -t 3133

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3133.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 10, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 10, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 390b20537d62fe5435ac0b8ce10a5d66a652893c 8346048: test/lib/containers/docker/DockerRunOptions.java uses addJavaOpts() from ctor Dec 10, 2025
@openjdk
Copy link

openjdk bot commented Dec 10, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Dec 10, 2025
@sendaoYan
Copy link
Member Author

sendaoYan commented Dec 10, 2025

This backport will make 8370966 backported cleanly.

@openjdk openjdk bot added the clean Identical backport; no merge resolution required label Dec 10, 2025
@openjdk
Copy link

openjdk bot commented Dec 10, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 10, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 10, 2025

Webrevs

gnu-andrew
gnu-andrew approved these changes Dec 19, 2025
View reviewed changes
Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change confirmed as a clean backport. I can't replicate the warning though and this will need to go to 21u & 17u first.

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 17, 2026

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gnu-andrew gnu-andrew gnu-andrew approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sendaoYan @gnu-andrew